linux-kernel - Re: [PATCH 3/5] driver: provide sysfs interfaces to access TXT log

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20130429140154.GA18818@kroah.com>
Date:	Mon, 29 Apr 2013 07:01:54 -0700
From:	Greg KH <gregkh@...uxfoundation.org>
To:	Andy Johnson <johnsonzjo@...il.com>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/5] driver: provide sysfs interfaces to access TXT log

On Mon, Apr 29, 2013 at 04:47:41PM +0300, Andy Johnson wrote:
> Hello
>   
> >Oh, and NEVER use "raw" kobjects, by doing that, you know you are >doing
> something wrong in a driver.
> 
> May I ask a short question  what do you mean by  "raw" kobjects? do you mean
> that 
> 
> struct kobject *log_kobj;
> 
> is a local variable inside a method and thus this is not 
> 
> ok?

I mean "a driver should almost never touch a 'struct kobject' directly,
or define it as a variable to be used."

Use the driver core (i.e. 'struct device' and friends), and not 'struct
kobject'.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/