linux-kernel - Re: [PATCH v2] modpost: fix unwanted VMLINUX_SYMBOL

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87y5c2ccj8.fsf@rustcorp.com.au>
Date:	Mon, 29 Apr 2013 11:40:19 +0930
From:	Rusty Russell <rusty@...tcorp.com.au>
To:	James Hogan <james.hogan@...tec.com>
Cc:	"H. Peter Anvin" <hpa@...or.com>,
	Tetsuo Handa <penguin-kernel@...ove.SAKURA.ne.jp>,
	arjan@...radead.org, linux-kernel@...r.kernel.org,
	andy.shevchenko@...il.com
Subject: Re: [PATCH v2] modpost: fix unwanted VMLINUX_SYMBOL_STR expansion

James Hogan <james.hogan@...tec.com> writes:
> Commit a4b6a77b77ba4f526392612c2365797fab956014 ("module: fix symbol
> versioning with symbol prefixes") broke the MODVERSIONS loading of any
> module using memcmp (e.g. ipv6) on x86_32, as it's defined to
> __builtin_memcmp which is expanded by VMLINUX_SYMBOL_STR. Use
> __VMLINUX_SYMBOL_STR instead which doesn't expand the argument.
>
> Reported-by: Tetsuo Handa <penguin-kernel@...ove.SAKURA.ne.jp>
> Reported-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> Signed-off-by: James Hogan <james.hogan@...tec.com>
> Cc: Rusty Russell <rusty@...tcorp.com.au>
> Cc: H. Peter Anvin <hpa@...or.com>
> Tested-by: Tetsuo Handa <penguin-kernel@...ove.SAKURA.ne.jp>
> Tested-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> ---
>
> I've corrected commit message tags for Rusty's convenience.
> Updated Reported-by to include Andy
> Taken the liberty of adding Tetsuo's Tested-by

Applied.

Thanks especially for chasing this: I was away for a few days last week.

Cheers,
Rusty.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/