linux-kernel - Re: [PATCH 1/1] kconfig: fix lists definition for C++

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <517EC9C7.9000903@infradead.org>
Date:	Mon, 29 Apr 2013 12:28:07 -0700
From:	Randy Dunlap <rdunlap@...radead.org>
To:	"Yann E. MORIN" <yann.morin.1998@...e.fr>
CC:	linux-kbuild@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-next@...r.kernel.org, Michal Marek <mmarek@...e.cz>,
	Benjamin Poirier <bpoirier@...e.de>
Subject: Re: [PATCH 1/1] kconfig: fix lists definition for C++

On 04/29/13 10:59, Yann E. MORIN wrote:
> From: "Yann E. MORIN" <yann.morin.1998@...e.fr>
> 
> The C++ compiler is more strict in that it refuses to assign
> a void* to a struct list_head*.
> 
> Fix that by explicitly casting the poisonning constants.
> 
> (Tested with all 5 frontends, now.)
> 
> Reported-by: Randy Dunlap <rdunlap@...radead.org>
> Signed-off-by: "Yann E. MORIN" <yann.morin.1998@...e.fr>
> Cc: Randy Dunlap <rdunlap@...radead.org>
> Cc: Benjamin Poirier <bpoirier@...e.de>

Acked-by: Randy Dunlap <rdunlap@...radead.org>

Thanks.

> ---
>  scripts/kconfig/list.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/scripts/kconfig/list.h b/scripts/kconfig/list.h
> index ea1d581..685d80e 100644
> --- a/scripts/kconfig/list.h
> +++ b/scripts/kconfig/list.h
> @@ -125,7 +125,7 @@ static inline void __list_del(struct list_head *prev, struct list_head *next)
>  static inline void list_del(struct list_head *entry)
>  {
>  	__list_del(entry->prev, entry->next);
> -	entry->next = LIST_POISON1;
> -	entry->prev = LIST_POISON2;
> +	entry->next = (struct list_head*)LIST_POISON1;
> +	entry->prev = (struct list_head*)LIST_POISON2;
>  }
>  #endif
> 


-- 
~Randy
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/