linux-kernel - Re: [GIT PATCH] USB patches for 3.10-rc1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+55aFzOf3tE=Mbrrwt_aOn6GdUv26VnJ=wsmY2sYC90-aUfLQ@mail.gmail.com>
Date:	Mon, 29 Apr 2013 14:31:59 -0700
From:	Linus Torvalds <torvalds@...ux-foundation.org>
To:	Alan Stern <stern@...land.harvard.edu>
Cc:	Greg KH <gregkh@...uxfoundation.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	USB list <linux-usb@...r.kernel.org>
Subject: Re: [GIT PATCH] USB patches for 3.10-rc1

On Mon, Apr 29, 2013 at 2:14 PM, Alan Stern <stern@...land.harvard.edu> wrote:
>
> What other things seemed odd about Greg's pull request?

The only other thing I noticed was the new CONFIG_USB_PHY quesiton,
which is not something that I think is sensible to ask from a user,
and the help text doesn't really help anything either.

I think the question may make sense, but the wording does not.

*EVERYBODY* wants a USB PHY. You can't have USB without a physical
layer unless it's a purely virtual device. There's one in a EHCI
controller too. It's like a network chip - without a PHY there's no
point. Why ask about whether you want to support a phy or not? The
question makes no sense.

So I don't think the question should be "do you want a USB PHY". The
question should be "Do you want a driver for some of the specialized
external USB controllers" or something like that. Because as it is
now, anybody who actually reads the question is likely to answer "y",
I think, even if he just wants one of the *normal* USB chips that
don't split out the PHY.

Hmm? Or does PHY have some magic other meaning in USB circles? In
which case the wording should still be totally redone to not be so
confusing and misleading.

                     Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/