linux-kernel - [PATCH 3.8-stable] kernel/audit_tree.c: tree will leak memory when failure occurs in audit_trim

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-id: <007001ce457e$dcfff1c0$96ffd540$%choi@samsung.com>
Date:	Tue, 30 Apr 2013 17:44:01 +0900
From:	Jonghwan Choi <jhbird.choi@...sung.com>
To:	'Jonghwan Choi' <jhbird.choi@...sung.com>,
	linux-kernel@...r.kernel.org
Cc:	stable@...r.kernel.org, 'Chen Gang' <gang.chen@...anux.com>,
	'Al Viro' <viro@...iv.linux.org.uk>
Subject: [PATCH 3.8-stable]  kernel/audit_tree.c: tree will leak memory when
 failure occurs in audit_trim_trees()

This patch looks like it should be in the 3.8-stable tree, should we apply
it?

------------------

From: "Chen Gang <gang.chen@...anux.com>"

commit 12b2f117f3bf738c1a00a6f64393f1953a740bd4 upstream

audit_trim_trees() calls get_tree().  If a failure occurs we must call
put_tree().

[akpm@...ux-foundation.org: run put_tree() before mutex_lock() for small
scalability improvement]
Signed-off-by: Chen Gang <gang.chen@...anux.com>
Cc: Al Viro <viro@...iv.linux.org.uk>
Cc: Eric Paris <eparis@...hat.com>
Signed-off-by: Andrew Morton <akpm@...ux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@...ux-foundation.org>
Signed-off-by: Jonghwan Choi <jhbird.choi@...sung.com>
---
 kernel/audit_tree.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/audit_tree.c b/kernel/audit_tree.c
index 642a89c..a291aa2 100644
--- a/kernel/audit_tree.c
+++ b/kernel/audit_tree.c
@@ -617,9 +617,9 @@ void audit_trim_trees(void)
 		}
 		spin_unlock(&hash_lock);
 		trim_marked(tree);
-		put_tree(tree);
 		drop_collected_mounts(root_mnt);
 skip_it:
+		put_tree(tree);
 		mutex_lock(&audit_filter_mutex);
 	}
 	list_del(&cursor);
-- 
1.7.9.5

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/