linux-kernel - [tip:perf/urgent] x86: Eliminate irq_mis_count counted in arch_irq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <tip-f7b0e1055574ce06ab53391263b4e205bf38daf3@git.kernel.org>
Date:	Tue, 30 Apr 2013 09:45:29 -0700
From:	tip-bot for Li Fei <tipbot@...or.com>
To:	linux-tip-commits@...r.kernel.org
Cc:	linux-kernel@...r.kernel.org, hpa@...or.com, mingo@...nel.org,
	stable@...nel.org, tglx@...utronix.de, chuansheng.liu@...el.com,
	fei.li@...el.com
Subject: [tip:perf/urgent] x86:
  Eliminate irq_mis_count counted in arch_irq_stat

Commit-ID:  f7b0e1055574ce06ab53391263b4e205bf38daf3
Gitweb:     http://git.kernel.org/tip/f7b0e1055574ce06ab53391263b4e205bf38daf3
Author:     Li Fei <fei.li@...el.com>
AuthorDate: Fri, 26 Apr 2013 20:50:11 +0800
Committer:  Ingo Molnar <mingo@...nel.org>
CommitDate: Tue, 30 Apr 2013 10:56:37 +0200

x86: Eliminate irq_mis_count counted in arch_irq_stat

With the current implementation, kstat_cpu(cpu).irqs_sum is also
increased in case of irq_mis_count increment.

So there is no need to count irq_mis_count in arch_irq_stat,
otherwise irq_mis_count will be counted twice in the sum of
/proc/stat.

Reported-by: Liu Chuansheng <chuansheng.liu@...el.com>
Signed-off-by: Li Fei <fei.li@...el.com>
Acked-by: Liu Chuansheng <chuansheng.liu@...el.com>
Cc: tomoki.sekiyama.qu@...achi.com
Cc: joe@...ches.com
Link: http://lkml.kernel.org/r/1366980611.32469.7.camel@fli24-HP-Compaq-8100-Elite-CMT-PC
Cc: <stable@...nel.org>
Signed-off-by: Ingo Molnar <mingo@...nel.org>
---
 arch/x86/kernel/irq.c | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/arch/x86/kernel/irq.c b/arch/x86/kernel/irq.c
index e4595f1..84b7789 100644
--- a/arch/x86/kernel/irq.c
+++ b/arch/x86/kernel/irq.c
@@ -165,10 +165,6 @@ u64 arch_irq_stat_cpu(unsigned int cpu)
 u64 arch_irq_stat(void)
 {
 	u64 sum = atomic_read(&irq_err_count);
-
-#ifdef CONFIG_X86_IO_APIC
-	sum += atomic_read(&irq_mis_count);
-#endif
 	return sum;
 }
 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/