linux-kernel - Re: [PATCH RESEND 1/2] watchdog: mtx1-wdt: use devm_gpio_request

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-id: <000401ce4545$979de350$c6d9a9f0$@samsung.com>
Date:	Tue, 30 Apr 2013 10:54:03 +0900
From:	Jingoo Han <jg1.han@...sung.com>
To:	'Guenter Roeck' <linux@...ck-us.net>
Cc:	'Andrew Morton' <akpm@...ux-foundation.org>,
	linux-kernel@...r.kernel.org, 'Wim Van Sebroeck' <wim@...ana.be>,
	linux-watchdog@...r.kernel.org, Jingoo Han <jg1.han@...sung.com>
Subject: Re: [PATCH RESEND 1/2] watchdog: mtx1-wdt: use devm_gpio_request_one()

On Tuesday, April 30, 2013 1:44 AM, Guenter Roeck wrote:
> On Mon, Apr 29, 2013 at 06:30:43PM +0900, Jingoo Han wrote:
> > Use devm_gpio_request_one() to make cleanup paths simpler.
> >
> > Signed-off-by: Jingoo Han <jg1.han@...sung.com>
> 
> This patch also addresses the missing gpio_free in the probe error path
> (if the call to misc_register() fails).

When devm_gpio_request_one() is used, there is no need to call
devm_gpio_free().

It is because, these resource managed functions such as
devm_gpio_request_one() allow the driver core to automatically
clean up any allocation, when probe function fails.

> 
> Reviewed-by: Guenter Roeck <linux@...ck-us.net>

Thank you for your reviewing.

Best regards,
Jingoo Han

> 
> > ---
> >  drivers/watchdog/mtx-1_wdt.c |    3 +--
> >  1 files changed, 1 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/watchdog/mtx-1_wdt.c b/drivers/watchdog/mtx-1_wdt.c
> > index 14dab6f..b434111 100644
> > --- a/drivers/watchdog/mtx-1_wdt.c
> > +++ b/drivers/watchdog/mtx-1_wdt.c
> > @@ -209,7 +209,7 @@ static int mtx1_wdt_probe(struct platform_device *pdev)
> >  	int ret;
> >
> >  	mtx1_wdt_device.gpio = pdev->resource[0].start;
> > -	ret = gpio_request_one(mtx1_wdt_device.gpio,
> > +	ret = devm_gpio_request_one(&pdev->dev, mtx1_wdt_device.gpio,
> >  				GPIOF_OUT_INIT_HIGH, "mtx1-wdt");
> >  	if (ret < 0) {
> >  		dev_err(&pdev->dev, "failed to request gpio");
> > @@ -241,7 +241,6 @@ static int mtx1_wdt_remove(struct platform_device *pdev)
> >  		wait_for_completion(&mtx1_wdt_device.stop);
> >  	}
> >
> > -	gpio_free(mtx1_wdt_device.gpio);
> >  	misc_deregister(&mtx1_wdt_misc);
> >  	return 0;
> >  }
> > --
> > 1.7.2.5
> >
> >
> > --
> > To unsubscribe from this list: send the line "unsubscribe linux-watchdog" in
> > the body of a message to majordomo@...r.kernel.org
> > More majordomo info at  http://vger.kernel.org/majordomo-info.html
> >

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/