linux-kernel - Re: [PATCH 1/1] ASoC: McASP: Add device tree binding for defining separate clock and sync used by tx and rx.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20130430184051.GF26160@sirena.org.uk>
Date:	Tue, 30 Apr 2013 19:40:51 +0100
From:	Mark Brown <broonie@...nel.org>
To:	Marek Belisko <marek.belisko@...il.com>
Cc:	lgirdwood@...il.com, perex@...ex.cz, tiwai@...e.de,
	grant.likely@...retlab.ca, rob.herring@...xeda.com,
	rob@...dley.net, zonque@...il.com,
	devicetree-discuss@...ts.ozlabs.org, linux-doc@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	Marek Belisko <marek.belisko@...eamunlimited.com>
Subject: Re: [PATCH 1/1] ASoC: McASP: Add device tree binding for defining
 separate clock and sync used by tx and rx.

On Tue, Apr 30, 2013 at 12:07:18PM +0200, Marek Belisko wrote:
> Add new property tx-rx-clk-separate which we can distinquish between common
> and separate clock for tx and rx blocks.

So, this is a sensible thing to have and in fact the core already has
the symmetric_rates flag for this.  This says two things to me.  One is
that this patch ought to at least set the symmetric_rates flag so that
the core can tell applications that we can't set different rates in each
direction.  The other is that this probably ought to be a generic
property for dai_links so that we can just set this for any driver -
even if the driver doesn't need to do anything it still matters to the
application layer.

What I'd suggest is adding code to check if symmetric_rates is set for
the DAI link and then key off that and then a generic DT thing (or just
set it in the machine driver for now if that makes sense) to enable that
for your board or boards.
machine driver).

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)