linux-kernel - Re: [PATCH] checkpatch: Make camelcase test --strict and less noisy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1367416238.4791.7.camel@dabdike.int.hansenpartnership.com>
Date:	Wed, 01 May 2013 06:50:38 -0700
From:	James Bottomley <James.Bottomley@...senPartnership.com>
To:	Borislav Petkov <bp@...en8.de>
Cc:	Joe Perches <joe@...ches.com>, Andy Whitcroft <apw@...onical.com>,
	linux-kernel <linux-kernel@...r.kernel.org>,
	linux-scsi <linux-scsi@...r.kernel.org>
Subject: Re: [PATCH] checkpatch: Make camelcase test --strict and less noisy

On Wed, 2013-05-01 at 14:34 +0200, Borislav Petkov wrote:
> On Thu, Apr 11, 2013 at 07:45:03AM -0700, Joe Perches wrote:
> > CamelCase tests are a bit noisy against certain
> > types of code acceptable to some kernel developers.
> > 
> > Make the test applicable only with --strict.
> > 
> > Do not bleat a message on nominally acceptable
> > CamelCase uses that are separated by an _ like
> > drm_core_has_MTRR.
> > 
> > Signed-off-by: Joe Perches <joe@...ches.com>
> > ---
> >  scripts/checkpatch.pl | 6 +++---
> >  1 file changed, 3 insertions(+), 3 deletions(-)
> > 
> > diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> > index 3fb6d86..97226fb 100755
> > --- a/scripts/checkpatch.pl
> > +++ b/scripts/checkpatch.pl
> > @@ -2937,12 +2937,12 @@ sub process {
> >  		while ($line =~ m{($Constant|$Lval)}g) {
> >  			my $var = $1;
> >  			if ($var !~ /$Constant/ &&
> > -			    $var =~ /[A-Z]\w*[a-z]|[a-z]\w*[A-Z]/ &&
> > +			    $var =~ /[A-Z][a-z]|[a-z][A-Z]/ &&
> >  			    $var !~ /"^(?:Clear|Set|TestClear|TestSet|)Page[A-Z]/ &&
> >  			    !defined $camelcase{$var}) {
> >  				$camelcase{$var} = 1;
> > -				WARN("CAMELCASE",
> > -				     "Avoid CamelCase: <$var>\n" . $herecurr);
> > +				CHK("CAMELCASE",
> > +				    "Avoid CamelCase: <$var>\n" . $herecurr);
> 
> Yep, this is better.

Fine with me ... I don't use --strict so it will make the message deluge
go away.

Thanks,

James


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/