linux-kernel - Re: [PATCH] init: Do not warn on non-zero initcall return

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+55aFzaBC5SFi7=F2mfm+KWY5qTsBmOqgbbs8E+LUS8JK-sBg@mail.gmail.com>
Date:	Wed, 1 May 2013 10:11:14 -0700
From:	Linus Torvalds <torvalds@...ux-foundation.org>
To:	Steven Rostedt <rostedt@...dmis.org>
Cc:	LKML <linux-kernel@...r.kernel.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Konrad Rzeszutek Wilk <konrad.wilk@...cle.com>
Subject: Re: [PATCH] init: Do not warn on non-zero initcall return

On Wed, May 1, 2013 at 8:02 AM, Steven Rostedt <rostedt@...dmis.org> wrote:
> Commit f91eb62f71 "init: scream bloody murder if interrupts are enabled
> too early" added three new warnings. The first two seemed reasonable,
> but the third included a warning when an initcall returned non-zero.
> Although, the third WARN() does include an imbalanced preempt disabled,
> or irqs disable, it shouldn't warn if it only had an initcall that just
> returns non-zero.

Ugh. Sorry, but this patch just looks stupid.

It seems that the right thing to do is to just remove the whole crappy

        if (ret && ret != -ENODEV && initcall_debug)
                sprintf(msgbuf, "error code %d ", ret);

thing entirely, since it's moronic to add that error code printout
anyway, since if initcall_debug is set, we already do a much *better*
job earlier with the whole

        pr_debug("initcall %pF returned %d after %lld usecs\n",
                 fn, ret, duration);

printout in do_one_initcall_debug().  That will then fix the WARN()
issue automatically.

Hmm?

              Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/