linux-kernel - Re: [PATCH 1/4] mmzone: make holding lock_memory_hotplug() a requirement for updating pgdat size

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.02.1305011525580.8804@chino.kir.corp.google.com>
Date:	Wed, 1 May 2013 15:26:37 -0700 (PDT)
From:	David Rientjes <rientjes@...gle.com>
To:	Cody P Schafer <cody@...ux.vnet.ibm.com>
cc:	Andrew Morton <akpm@...ux-foundation.org>,
	Linux MM <linux-mm@...ck.org>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/4] mmzone: make holding lock_memory_hotplug() a
 requirement for updating pgdat size

On Wed, 1 May 2013, Cody P Schafer wrote:

> All updaters of pgdat size (spanned_pages, start_pfn, and
> present_pages) currently also hold lock_memory_hotplug() (in addition
> to pgdat_resize_lock()).
> 
> Document this and make holding of that lock a requirement on the update
> side for now, but keep the pgdat_resize_lock() around for readers that
> can't lock a mutex.
> 
> Signed-off-by: Cody P Schafer <cody@...ux.vnet.ibm.com>

Nack, these fields are initialized at boot without lock_memory_hotplug(), 
so you're statement is wrong, and all you need is pgdat_resize_lock().
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/