linux-kernel - Re: [PATCH 2/3] ASoC: ux500: move clock controls to ab8500-codec

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130502094833.GA1590@balto.lan>
Date:	Thu, 2 May 2013 11:48:33 +0200
From:	Fabio Baltieri <fabio.baltieri@...aro.org>
To:	Mark Brown <broonie@...nel.org>
Cc:	Liam Girdwood <lgirdwood@...il.com>, alsa-devel@...a-project.org,
	linux-kernel@...r.kernel.org,
	Linus Walleij <linus.walleij@...aro.org>,
	Lee Jones <lee.jones@...aro.org>,
	Ola Lilja <ola.o.lilja@...ricsson.com>
Subject: Re: [PATCH 2/3] ASoC: ux500: move clock controls to ab8500-codec

On Thu, May 02, 2013 at 09:54:21AM +0200, Fabio Baltieri wrote:
> On Tue, Apr 30, 2013 at 07:30:35PM +0100, Mark Brown wrote:
> > On Tue, Apr 30, 2013 at 04:09:53PM +0200, Fabio Baltieri wrote:
> > > Move ab8500 clock control definitions to the ab8500 codec driver,
> > > leaving only card specific setting in mop500_ab8500_ctrls.
> > 
> > So, if this is some generic thing and not some weird stuff for the card
> > this really reopens the question about why this is done with user
> > visible controls...
> > 
> > >  static struct snd_kcontrol_new ab8500_ctrls[] = {
> > > +	/* Digital interface - Clocks */
> > > +	SOC_SINGLE("Digital Interface Master Generator Switch",
> > > +		AB8500_DIGIFCONF1, AB8500_DIGIFCONF1_ENMASTGEN,
> > > +		1, 0),
> > > +	SOC_SINGLE("Digital Interface 0 Bit-clock Switch",
> > > +		AB8500_DIGIFCONF1, AB8500_DIGIFCONF1_ENFSBITCLK0,
> > > +		1, 0),
> > > +	SOC_SINGLE("Digital Interface 1 Bit-clock Switch",
> > > +		AB8500_DIGIFCONF1, AB8500_DIGIFCONF1_ENFSBITCLK1,
> > > +		1, 0),
> > 
> > ...this is all stuff that is normally figured out automatically by the
> > drivers, we know when the audio interface is in use and hence when it
> > needs to be clocked.
> 
> It makes sense, I'll poke the documentation I have and try to figure out
> how to control those bits from a more appropriate place.

Well, it looks like this is *already* handled automatically by the
ab8500 codec driver in ab8500_codec_set_dai_clock_gate(), and these
controls just allow some messy degree of overriding after the audio
stream is started.  At this point the only thing that comes to my mind
is that this is some debug leftover and I'm replying with a v2 to just
drop these three widgets altogether.

In the meantime, I'm also observing some funny behavior of other
alsamixer controls, but I'll fix those on a separate series.  This is
enough to bring the driver back on a working state.

Thanks,
Fabio

-- 
Fabio Baltieri
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/