linux-kernel - Re: [PATCH 1/8] rsxx: Adding in debugfs entries.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130502140753.GS7800@kernel.dk>
Date:	Thu, 2 May 2013 16:07:53 +0200
From:	Jens Axboe <axboe@...nel.dk>
To:	"Philip J. Kelleher" <pjk1939@...ux.vnet.ibm.com>
Cc:	linux-kernel@...r.kernel.org, klebers@...ux.vnet.ibm.com,
	brking@...ux.vnet.ibm.com
Subject: Re: [PATCH 1/8] rsxx: Adding in debugfs entries.

On Thu, May 02 2013, Philip J. Kelleher wrote:
> On Thu, May 02, 2013 at 10:03:25AM +0200, Jens Axboe wrote:
> > On Wed, May 01 2013, Philip J. Kelleher wrote:
> > >  #define NO_LEGACY 0
> > > +#define DEBUGFS_NULL NULL
> > >  
> > > +static struct dentry *rsxx_debugfs_root = DEBUGFS_NULL;
> > 
> > What's the point of DEBUGFS_NULL?
> 
> Well, orginally, I had rsxx_debugfs_root initialized to NULL but
> the checkpatch script told me not to initialize directly with 0
> or NULL. So my solution is the #define macro.

Well, it's a static variable. The reason checkpatch tells you not to
initialize it to NULL/0 is because the bss is automatically zeroed.

-- 
Jens Axboe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/