linux-kernel - Re: [PATCH] powerpc: Make Book E watchdog reset type configurable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130502161720.GA7797@roeck-us.net>
Date:	Thu, 2 May 2013 09:17:20 -0700
From:	Guenter Roeck <linux@...ck-us.net>
To:	dirk.eibach@...ys.cc
Cc:	linux-kernel@...r.kernel.org,
	Kumar Gala <galak@...nel.crashing.org>,
	Wim Van Sebroeck <wim@...ana.be>,
	linux-watchdog@...r.kernel.org
Subject: Re: [PATCH] powerpc: Make Book E watchdog reset type configurable

On Thu, May 02, 2013 at 04:45:13PM +0200, dirk.eibach@...ys.cc wrote:
> From: Dirk Eibach <dirk.eibach@...ys.cc>
> 
> Signed-off-by: Dirk Eibach <dirk.eibach@...ys.cc>
> Cc: Kumar Gala <galak@...nel.crashing.org>
> Cc: Wim Van Sebroeck <wim@...ana.be>
> Cc: linux-watchdog@...r.kernel.org
> ---
>  drivers/watchdog/Kconfig     |   32 ++++++++++++++++++++++++++++++++
>  drivers/watchdog/booke_wdt.c |   10 +++++++++-
>  2 files changed, 41 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/watchdog/Kconfig b/drivers/watchdog/Kconfig
> index e89fc31..6048593 100644
> --- a/drivers/watchdog/Kconfig
> +++ b/drivers/watchdog/Kconfig
> @@ -1172,6 +1172,38 @@ config BOOKE_WDT_DEFAULT_TIMEOUT
>  
>  	  The value can be overridden by the wdt_period command-line parameter.
>  
> +choice
> +	prompt "PowerPC Book-E Watchdog reset type"
> +	depends on BOOKE_WDT
> +	default BOOKE_WDT_RESET_CHIP
> +	help
> +	  Specify what kind of reset will be executed on watchdog timeout.
> +
Seems to me it would be much better to make this configurable via platform data 
and/or device tree.

Guenter
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/