linux-kernel - Re: [PULLv2] vhost: cleanups and fixes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+55aFyzq+EBHiKYyEw3OXWKeeTbwt1sCYACfD4YsOWCBBZTVQ@mail.gmail.com>
Date:	Thu, 2 May 2013 13:26:41 -0700
From:	Linus Torvalds <torvalds@...ux-foundation.org>
To:	"Michael S. Tsirkin" <mst@...hat.com>
Cc:	KVM list <kvm@...r.kernel.org>, virtualization@...ts.osdl.org,
	Network Development <netdev@...r.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Asias He <asias@...hat.com>,
	"Nicholas A. Bellinger" <nab@...ux-iscsi.org>
Subject: Re: [PULLv2] vhost: cleanups and fixes

On Thu, May 2, 2013 at 1:11 PM, Michael S. Tsirkin <mst@...hat.com> wrote:
> Hi Linus,
> This is exactly same code as my previous pull sent earlier, the diffstat
> was wrong however, I did a merge with master which fixed that.

See my other email. THIS IS NOT A VALID REASON TO DO A BACK-MERGE!

Extraneous merge commits that have no actual reason for development
are bad. They make it much harder to see what the actual development
thread was, because they mix up different branches. In fact, the whole
problem with the diffstat started with *another* extraneous merge, so
the "fix" was a result of a previous merge. This is exactly the kind
of reason why we want merges to be done by upstream developers, not
"back-merges" by downstream.

Now that merge is in your development tree, and if/when you start
doing development on top of that, the same kind of problem will
continue. Together with making it much harder to see in the history
what _your_ development stream was, because now it's no longer linear
and mixes in random points of the merge window.

Don't do this. Why do I have to write one of these "DON'T DO
BACK-MERGES" every single merge window? I really wish people listened,
instead of every single developer deciding that "it's ok if _I_ do it,
I'm sure Linus is complaining about all those *other* morons out
there".

When I say "don't do back-merges", I mean *you*. Yes, you. Not
somebody else. You.

                  Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/