linux-kernel - [PATCH 1/2] f2fs: Continue to mount after failing recovery

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:	Thu, 02 May 2013 15:48:40 -0500
From:	Chris Fries <ccfries@...il.com>
To:	c.fries@...orola.com, jason.hrycay@...orola.com,
	linux-f2fs-devel@...ts.sourceforge.net,
	linux-kernel@...r.kernel.org, jaegeuk.kim@...sung.com
Subject: [PATCH 1/2] f2fs: Continue to mount after failing recovery

From: Chris Fries <C.Fries@...orola.com>

When unable to roll forward the journal, we shouldn't bail out and
not mount, we should continue to attempt the mount.  Bad recovery data
is likely unrecoverable at this point, and requiring the user to try
to mount again doesn't solve any issues.

Signed-off-by: Chris Fries <C.Fries@...orola.com>
Reviewed-by: Russell Knize <rknize2@...orola.com>
Reviewed-by: Jason Hrycay <jason.hrycay@...orola.com>
---
  fs/f2fs/super.c | 7 +++----
  1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/fs/f2fs/super.c b/fs/f2fs/super.c
index 2643c49..d8f7ed3 100644
--- a/fs/f2fs/super.c
+++ b/fs/f2fs/super.c
@@ -649,10 +649,9 @@ static int f2fs_fill_super(struct super_block *sb, 
void *data, int silent)
      /* recover fsynced data */
      if (!test_opt(sbi, DISABLE_ROLL_FORWARD)) {
          err = recover_fsync_data(sbi);
-        if (err) {
-            f2fs_msg(sb, KERN_ERR, "Failed to recover fsync data");
-            goto free_root_inode;
-        }
+        if (err)
+            f2fs_msg(sb, KERN_ERR,
+                "Cannot recover all fsync data, continue\n");
      }

      /* After POR, we can run background GC thread */
-- 
1.8.0

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/