linux-kernel - Re: clockevents_program_event WARN

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 2 May 2013 23:19:02 +0200 (CEST)
From:	Thomas Gleixner <tglx@...utronix.de>
To:	Yinghai Lu <yinghai@...nel.org>
cc:	Dave Jones <davej@...hat.com>,
	Linux Kernel <linux-kernel@...r.kernel.org>
Subject: Re: clockevents_program_event WARN_ON preventing boot.

On Thu, 2 May 2013, Yinghai Lu wrote:
> On Thu, May 2, 2013 at 12:58 PM, Thomas Gleixner <tglx@...utronix.de> wrote:
> 
> >
> > The check should be:
> >
> >     if (td->evtdev && tick_device_is_functional(td->evtdev))
> 
> still happens.
> 
> [    3.457866] checking TSC synchronization [CPU#0 -> CPU#10]: passed.
> [    3.460806] SMP alternatives: lockdep: fixing up alternatives
> [    3.464282] ------------[ cut here ]------------
> [    3.464297] WARNING: at kernel/time/clockevents.c:209
> clockevents_program_event+0x3b/0x100()

I didn't expect it to fix the warning, I just wanted to prevent the
crash which Dave decoded. Though the warning and the crash have
probably the same root cause...

> [    3.464300] Modules linked in:
> [    3.464306] CPU: 10 PID: 0 Comm: swapper/10 Not tainted
> 3.9.0-yh-08066-g1252014-dirty #1537
> [    3.464308] Hardware name: Oracle Corporation  unknown       /
> , BIOS 11016600    05/17/2011
> [    3.464327]  0000000000000009 ffff88203e203ed8 ffffffff82091022
> ffff88203e203f18
> [    3.464343]  ffffffff81088990 ffff88203e203f08 80000000003d08ff
> 80000000003d08ff
> [    3.464359]  000000000000000a ffff881027557fd8 0000000000000000
> ffff88203e203f28
> [    3.464361] Call Trace:
> [    3.464379]  <IRQ>  [<ffffffff82091022>] dump_stack+0x19/0x1b
> [    3.464392]  [<ffffffff81088990>] warn_slowpath_common+0x70/0xa0
> [    3.464395]  [<ffffffff810889da>] warn_slowpath_null+0x1a/0x20
> [    3.464399]  [<ffffffff810e312b>] clockevents_program_event+0x3b/0x100
> [    3.464403]  [<ffffffff810e35ec>] tick_handle_periodic+0x4c/0x80

Now, that's really odd.

     next = ktime_add(dev->next_event, tick_period);

     clockevents_program_event(dev, next, false);

     and next.tv64 is < 0 !?!

Can you please apply the following debug patch and provide the output?

Thanks,

	tglx

diff --git a/kernel/time/clockevents.c b/kernel/time/clockevents.c
index c6d6400..b4d9622 100644
--- a/kernel/time/clockevents.c
+++ b/kernel/time/clockevents.c
@@ -207,6 +207,8 @@ int clockevents_program_event(struct clock_event_device *dev, ktime_t expires,
 
 	if (unlikely(expires.tv64 < 0)) {
 		WARN_ON_ONCE(1);
+		printk_once(KERN_INFO "expires %llx, dev->next %llx\n",
+			    expires.tv64, dev->next_event.tv64);
 		return -ETIME;
 	}
 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/