linux-kernel - Re: [PATCH] NOHZ, check to see if tick device is initialized in IRQ handling path

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 2 May 2013 15:51:47 -0700
From:	Tony Luck <tony.luck@...il.com>
To:	Prarit Bhargava <prarit@...hat.com>
Cc:	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Thomas Gleixner <tglx@...utronix.de>,
	John Stultz <john.stultz@...aro.org>
Subject: Re: [PATCH] NOHZ, check to see if tick device is initialized in IRQ
 handling path

>  void tick_nohz_irq_exit(void)
>  {
>         struct tick_sched *ts = &__get_cpu_var(tick_cpu_sched);
> +       struct clock_event_device *dev =
> +                                    __get_cpu_var(tick_cpu_device).evtdev;
> +
> +       /* Has the tick been initialized yet? */
> +       if (unlikely(!dev || dev->mode == CLOCK_EVT_MODE_UNUSED))
> +               return;

Could we have something in the "struct tick_sched" to tell us whether
it has been set up? Rather than this somewhat convoluted digging
around in the clock_event_device innards?

> +       if (unlikely(!dev || dev->mode == CLOCK_EVT_MODE_UNUSED))
> +               return;

Ditto here.

-Tony
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/