linux-kernel - Re: [PATCH V2] cpufreq: cpu0: Free parent node for error cases

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130503060327.GA19902@S2101-09.ap.freescale.net>
Date:	Fri, 3 May 2013 14:03:29 +0800
From:	Shawn Guo <shawn.guo@...aro.org>
To:	Viresh Kumar <viresh.kumar@...aro.org>
CC:	<rjw@...k.pl>, <linaro-kernel@...ts.linaro.org>,
	<patches@...aro.org>, <cpufreq@...r.kernel.org>,
	<linux-pm@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
	<robin.randhawa@....com>, <Steve.Bannister@....com>,
	<Liviu.Dudau@....com>, <charles.garcia-tobin@....com>,
	<arvind.chauhan@....com>
Subject: Re: [PATCH V2] cpufreq: cpu0: Free parent node for error cases

On Fri, May 03, 2013 at 10:14:25AM +0530, Viresh Kumar wrote:
> We are freeing parent node in success cases but not in failure cases. Lets do
> it.
> 
> Signed-off-by: Viresh Kumar <viresh.kumar@...aro.org>

Acked-by: Shawn Guo <shawn.guo@...aro.org>

> ---
>  drivers/cpufreq/cpufreq-cpu0.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/cpufreq/cpufreq-cpu0.c b/drivers/cpufreq/cpufreq-cpu0.c
> index 3ab8294..8565d41 100644
> --- a/drivers/cpufreq/cpufreq-cpu0.c
> +++ b/drivers/cpufreq/cpufreq-cpu0.c
> @@ -189,7 +189,8 @@ static int cpu0_cpufreq_probe(struct platform_device *pdev)
>  
>  	if (!np) {
>  		pr_err("failed to find cpu0 node\n");
> -		return -ENOENT;
> +		ret = -ENOENT;
> +		goto out_put_parent;
>  	}
>  
>  	cpu_dev = &pdev->dev;
> @@ -264,6 +265,8 @@ out_free_table:
>  	opp_free_cpufreq_table(cpu_dev, &freq_table);
>  out_put_node:
>  	of_node_put(np);
> +out_put_parent:
> +	of_node_put(parent);
>  	return ret;
>  }
>  
> -- 
> 1.7.12.rc2.18.g61b472e
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/