linux-kernel - Re: [PATCH 38/42] rtc: rtc-vt8500: remove unnecessary platform_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 03 May 2013 19:27:15 +1200
From:	Tony Prisk <linux@...sktech.co.nz>
To:	Jingoo Han <jg1.han@...sung.com>
CC:	'Andrew Morton' <akpm@...ux-foundation.org>,
	linux-kernel@...r.kernel.org,
	'Alessandro Zummo' <a.zummo@...ertech.it>,
	rtc-linux@...glegroups.com
Subject: Re: [PATCH 38/42] rtc: rtc-vt8500: remove unnecessary platform_set_drvdata()

On 03/05/13 18:38, Jingoo Han wrote:
> The driver core clears the driver data to NULL after device_release
> or on probe failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d
> (device-core: Ensure drvdata = NULL when no driver is bound).
> Thus, it is not needed to manually clear the device driver data to NULL.
>
> Signed-off-by: Jingoo Han <jg1.han@...sung.com>
> ---
>   drivers/rtc/rtc-vt8500.c |    2 --
>   1 files changed, 0 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/rtc/rtc-vt8500.c b/drivers/rtc/rtc-vt8500.c
> index d89efee..c2d6331 100644
> --- a/drivers/rtc/rtc-vt8500.c
> +++ b/drivers/rtc/rtc-vt8500.c
> @@ -282,8 +282,6 @@ static int vt8500_rtc_remove(struct platform_device *pdev)
>   	/* Disable alarm matching */
>   	writel(0, vt8500_rtc->regbase + VT8500_RTC_IS);
>   
> -	platform_set_drvdata(pdev, NULL);
> -
>   	return 0;
>   }
>   
Acked-by: Tony Prisk <linux@...sktech.co.nz>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/