linux-kernel - Re: [PATCH 0/5] various ab8500 fixes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20130503080125.GC24153@gmail.com>
Date:	Fri, 3 May 2013 09:01:25 +0100
From:	Lee Jones <lee.jones@...aro.org>
To:	Fabio Baltieri <fabio.baltieri@...aro.org>
Cc:	Samuel Ortiz <sameo@...ux.intel.com>,
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
	Linus Walleij <linus.walleij@...aro.org>,
	Srinidhi Kasagar <srinidhi.kasagar@...ricsson.com>
Subject: Re: [PATCH 0/5] various ab8500 fixes

On Fri, 26 Apr 2013, Fabio Baltieri wrote:

> Hi Samuel,
> 
> this series contains various fixes I found on the current -next ab8500
> driver(s).
> 
> Patches 1 and 2 are just sparse warning, patch 3 drops reference to a
> superseeded driver and last two makes ab8500-sysctrl works again without
> an explicit ab8500->sysctrl defined, as it is in current kernel.
> 
> Thanks,
> Fabio
> 
> 
> Fabio Baltieri (5):
>   mfd: abx500-core: fix sparse warning
>   mfd: ab8500-sysctrl: fix sparse warning
>   mfd: ab8500: drop references to ab8500-leds
>   mfd: ab8500-sysctrl: set sysctrl_dev during probe
>   mfd: ab8500-sysctrl: let sysctrl driver work without pdata

I have a really petty point:

Try and keep to the $SUBJECT line conventions which are preferred by
each subsystem maintainer. Linus Walleij tends to prefer the scheme
you've used above, but Sam likes the description to start with an
uppercase character. No biggy, I'll just fix that up for you.

>  drivers/mfd/ab8500-core.c    | 13 -------------
>  drivers/mfd/ab8500-sysctrl.c |  9 +++++----
>  drivers/mfd/abx500-core.c    |  2 +-
>  3 files changed, 6 insertions(+), 18 deletions(-)

All patches applied. Thanks Fabio.

-- 
Lee Jones
Linaro ST-Ericsson Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/