linux-kernel - Re: [PATCH] powerpc: Make Book E watchdog reset type configurable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7be2cb3417615ff206270a756c6422d6@gdsys.cc>
Date:	Fri, 03 May 2013 10:33:13 +0200
From:	Dirk Eibach <dirk.eibach@...ys.cc>
To:	Guenter Roeck <linux@...ck-us.net>
Cc:	<linux-kernel@...r.kernel.org>,
	Kumar Gala <galak@...nel.crashing.org>,
	Wim Van Sebroeck <wim@...ana.be>,
	<linux-watchdog@...r.kernel.org>,
	<devicetree-discuss@...ts.ozlabs.org>
Subject: Re: [PATCH] powerpc: Make Book E watchdog reset type configurable

Hi Guenter,

>>>> diff --git a/drivers/watchdog/Kconfig b/drivers/watchdog/Kconfig
>>>> index e89fc31..6048593 100644
>>>> --- a/drivers/watchdog/Kconfig
>>>> +++ b/drivers/watchdog/Kconfig
>>>> @@ -1172,6 +1172,38 @@ config BOOKE_WDT_DEFAULT_TIMEOUT
>>>> 
>>>> 	  The value can be overridden by the wdt_period command-line
>>>> parameter.
>>>> 
>>>> +choice
>>>> +	prompt "PowerPC Book-E Watchdog reset type"
>>>> +	depends on BOOKE_WDT
>>>> +	default BOOKE_WDT_RESET_CHIP
>>>> +	help
>>>> +	  Specify what kind of reset will be executed on watchdog 
>>>> timeout.
>>>> +
>>> Seems to me it would be much better to make this configurable via
>>> platform data
>>> and/or device tree.
>> 
>> good catch. What do the device-tree gurus think to be a nice
>> property name?

having a closer look, I realized booke_wdt is not device-tree based 
yet. Migrating it would come close to a rewrite, breaking compatibility 
for all current users. Sorry, this is way beyond the time I have for 
this project. So I suggest merging the change the way it is, as it is 
clearly an improvement.

Cheers
Dirk
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/