linux-kernel - Re: [PATCH 03/42] rtc: rtc-ab3100: remove unnecessary platform_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <51838F2B.5020402@metafoo.de>
Date:	Fri, 03 May 2013 12:19:23 +0200
From:	Lars-Peter Clausen <lars@...afoo.de>
To:	Jingoo Han <jg1.han@...sung.com>
CC:	'Andrew Morton' <akpm@...ux-foundation.org>,
	linux-kernel@...r.kernel.org,
	'Alessandro Zummo' <a.zummo@...ertech.it>,
	rtc-linux@...glegroups.com
Subject: Re: [PATCH 03/42] rtc: rtc-ab3100: remove unnecessary platform_set_drvdata()

On 05/03/2013 08:22 AM, Jingoo Han wrote:
> The driver core clears the driver data to NULL after device_release
> or on probe failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d
> (device-core: Ensure drvdata = NULL when no driver is bound).
> Thus, it is not needed to manually clear the device driver data to NULL.
> 
> Signed-off-by: Jingoo Han <jg1.han@...sung.com>
> ---
>  drivers/rtc/rtc-ab3100.c |    1 -
>  1 files changed, 0 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/rtc/rtc-ab3100.c b/drivers/rtc/rtc-ab3100.c
> index 47a4f2c..572208d 100644
> --- a/drivers/rtc/rtc-ab3100.c
> +++ b/drivers/rtc/rtc-ab3100.c
> @@ -242,7 +242,6 @@ static int __init ab3100_rtc_probe(struct platform_device *pdev)
>  
>  static int __exit ab3100_rtc_remove(struct platform_device *pdev)
>  {
> -	platform_set_drvdata(pdev, NULL);
>  	return 0;
>  }

Since it's empty you can remove the function altogether.

Same comment for all the other patches in this series where the function
ends up being empty

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/