[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <6539209.phsENQLmv5@vostro.rjw.lan>
Date: Fri, 03 May 2013 13:43:46 +0200
From: "Rafael J. Wysocki" <rjw@...k.pl>
To: Tejun Heo <tj@...nel.org>
Cc: Colin Cross <ccross@...roid.com>, Oleg Nesterov <oleg@...hat.com>,
linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org,
arve@...roid.com
Subject: Re: [PATCH v2 00/10] optimize freezing tasks by reducing task wakeups
On Thursday, May 02, 2013 05:10:26 PM Tejun Heo wrote:
> Hey, Rafael.
>
> On Thu, May 02, 2013 at 11:06:35PM +0200, Rafael J. Wysocki wrote:
> > > v2 moves the skip check to freeze_task(), and expands the commit
> > > messages.
> >
> > The entire series makes sense to me, so are there any objections?
> >
> > Tejun, Oleg??
>
> Generally looks good to me. I'm a bit uncomfortable with the
> generic-looking expansion of the freezable API as it can't be
> something which can be used in any generic manner. It'd be great if
> we just add only the used ones (do we already?)
I'm not sure about that, unfortunately.
> and add some sort of lockdep annotation so that people don't use them while
> holding any locks.
I guess we can add that anyway?
Rafael
--
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists