linux-kernel - Re: [PATCH 40/42] rtc: rtc-puv3: remove unnecessary platform_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sat, 4 May 2013 00:30:29 +0800 (CST)
From:	"Xuetao Guan" <gxt@...c.pku.edu.cn>
To:	"Jingoo Han" <jg1.han@...sung.com>
Cc:	"'Andrew Morton'" <akpm@...ux-foundation.org>,
	linux-kernel@...r.kernel.org,
	"'Alessandro Zummo'" <a.zummo@...ertech.it>,
	rtc-linux@...glegroups.com, "Jingoo Han" <jg1.han@...sung.com>,
	"'Guan Xuetao'" <gxt@...c.pku.edu.cn>
Subject: Re: [PATCH 40/42] rtc: rtc-puv3: remove unnecessary 
     platform_set_drvdata()

> The driver core clears the driver data to NULL after device_release
> or on probe failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d
> (device-core: Ensure drvdata = NULL when no driver is bound).
> Thus, it is not needed to manually clear the device driver data to NULL.
>
> Signed-off-by: Jingoo Han <jg1.han@...sung.com>
Thanks.

Acked-by: Guan Xuetao <gxt@...c.pku.edu.cn>

> ---
>  drivers/rtc/rtc-puv3.c |    1 -
>  1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/rtc/rtc-puv3.c b/drivers/rtc/rtc-puv3.c
> index 72f4371..402732c 100644
> --- a/drivers/rtc/rtc-puv3.c
> +++ b/drivers/rtc/rtc-puv3.c
> @@ -224,7 +224,6 @@ static int puv3_rtc_remove(struct platform_device
> *dev)
>  {
>  	struct rtc_device *rtc = platform_get_drvdata(dev);
>
> -	platform_set_drvdata(dev, NULL);
>  	rtc_device_unregister(rtc);
>
>  	puv3_rtc_setpie(&dev->dev, 0);
> --
> 1.7.2.5
>
>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/