linux-kernel - Re: [PATCH] iscsi-target: Make buf param of iscsit_do_crypto_hash

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMuHMdUOXbPkJf0Y1hupmmeotO6teFL1xJubRY0nBsTVu7=hBw@mail.gmail.com>
Date:	Fri, 3 May 2013 23:22:34 +0200
From:	Geert Uytterhoeven <geert@...ux-m68k.org>
To:	"Nicholas A. Bellinger" <nab@...ux-iscsi.org>
Cc:	scsi <linux-scsi@...r.kernel.org>,
	target-devel <target-devel@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Geert Uytterhoeven <geert@...ux-m68k.org>
Subject: Re: [PATCH] iscsi-target: Make buf param of iscsit_do_crypto_hash_buf()
 const void *

On Fri, May 3, 2013 at 11:15 PM, Geert Uytterhoeven
<geert@...ux-m68k.org> wrote:
> --- a/drivers/target/iscsi/iscsi_target.c
> +++ b/drivers/target/iscsi/iscsi_target.c

> @@ -3585,9 +3575,8 @@ static int iscsit_send_reject(
>         }
>
>         if (conn->conn_ops->DataDigest) {
> -               iscsit_do_crypto_hash_buf(&conn->conn_tx_hash,
> -                               (unsigned char *)cmd->buf_ptr, ISCSI_HDR_LEN,
> -                               0, NULL, (u8 *)&cmd->data_crc);
> +               iscsit_do_crypto_hash_buf(&conn->conn_tx_hash, cmd->buf_ptr,
> +                               ISCSI_HDR_LEN, 0, NULL, (u8 *)&cmd->data_crc);

BTW, there are serious issues with casting pointers to u32s to pointers to u8s
for the last two output parameters of iscsit_do_crypto_hash_buf() (pad_bytes
and data_crc):
  1. It's not endian-safe,
  2. In many cases, the original u32 was not initialized at all, so the other 24
      bits contain garbage. This will cause 32-bit comparisons like

        if (checksum != data_crc)

     to fail in unpredictable ways.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/