linux-kernel - Re: [git pull] GPIO for v3.10

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+55aFyne+nPjPWPByN+2C83oMehOHjDKNynpaniHAdz2KmsdQ@mail.gmail.com>
Date:	Fri, 3 May 2013 14:48:48 -0700
From:	Linus Torvalds <torvalds@...ux-foundation.org>
To:	Jean Delvare <khali@...ux-fr.org>
Cc:	Grant Likely <grant.likely@...retlab.ca>,
	Marek Vasut <marex@...x.de>,
	Linus Walleij <linus.walleij@...aro.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Samuel Ortiz <samuel@...tiz.org>
Subject: Re: [git pull] GPIO for v3.10

On Fri, May 3, 2013 at 2:22 PM, Jean Delvare <khali@...ux-fr.org> wrote:
>
> It means that nobody test-compiled that tree with CONFIG_GPIO_UCB1400=m.

And you are making that excuse exactly *why*?

Especially when one of the commits was to allow it. Especially since
the minimal you could expect is a "make allmodconfig" on the most
common platform out there.

Stop making excuses for bad behavior. Just admit that you guys screwed
up rather than trying to soldier on.

If this was some uncommon case like "it doesn't work on s390" or
"there was a subtle interaction with other changes", I'd be less
pissed off. But this was literally a commit that did *one* thing, and
one thing only ("driver can be compiled as a module") and nobody had
tested that *one* thing that the commit did.

That's a f*cking disgrace. That's not the kind of tree you should
expect me to be happy about pulling.

Stop making excuses for it. Really. It just makes you look even worse.
The only correct reply was the one that Grant already sent, which was
basically "sorry, that was wrong, my bad".

Next merge window I will have forgotten, and maybe people will have
learnt to do some minimal testing of the stuff they send me. In the
meantime, don't try to make it look like this was all ok.

                    Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/