linux-kernel - Re: [PATCH V4 4/9] mtd: get the ECC info from the Extended Parameter Page

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <51832685.8030503@freescale.com>
Date:	Fri, 3 May 2013 10:52:53 +0800
From:	Huang Shijie <b32955@...escale.com>
To:	Brian Norris <computersforpeace@...il.com>
CC:	<dwmw2@...radead.org>, <dedekind1@...il.com>,
	<linux-mtd@...ts.infradead.org>, <linux-kernel@...r.kernel.org>,
	"Gupta, Pekon" <pekon@...com>
Subject: Re: [PATCH V4 4/9] mtd: get the ECC info from the Extended Parameter
 Page

于 2013年05月03日 07:39, Brian Norris 写道:
> only run the extended parameter page function after that point.
sorry, I prefer to run the extended parameter page function here just 
following the case
"p-> ecc_bits != 0xff". IMHO, the two cases should be put together as 
the onfi spec tells, rather be split out
far away. The extended parameter page function is just the case 
"p->ecc_bits == 0xff".

If we put the nand_flash_detect_ext_param_page() after the point we 
reassign the chip->cmdfunc,
It's a little discrete in logic which makes the code not compact enough.

btw: Could you check you email client? I failed several times for the 
HTML issue.

thanks
Huang Shijie


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/