linux-kernel - [PATCH] idr: Print a stack dump after ida

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 05 May 2013 11:32:03 +0200
From:	Jean Delvare <jdelvare@...e.de>
To:	linux-kernel <linux-kernel@...r.kernel.org>
Cc:	Tejun Heo <tj@...nel.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Takashi Iwai <tiwai@...e.de>
Subject: [PATCH] idr: Print a stack dump after ida_remove warning

We print a dump stack after idr_remove warning. This is useful to find
the faulty piece of code. Let's do the same for ida_remove, as it
would be equally useful there.

Signed-off-by: Jean Delvare <jdelvare@...e.de>
Cc: Tejun Heo <tj@...nel.org>
Cc: Andrew Morton <akpm@...ux-foundation.org>
Cc: Takashi Iwai <tiwai@...e.de>
---
 lib/idr.c |    1 +
 1 file changed, 1 insertion(+)

--- linux-3.10-rc0.orig/lib/idr.c	2013-05-05 10:17:03.086198024 +0200
+++ linux-3.10-rc0/lib/idr.c	2013-05-05 10:41:11.939134735 +0200
@@ -1066,6 +1066,7 @@ void ida_remove(struct ida *ida, int id)
  err:
 	printk(KERN_WARNING
 	       "ida_remove called for id=%d which is not allocated.\n", id);
+	dump_stack();
 }
 EXPORT_SYMBOL(ida_remove);
 

-- 
Jean Delvare
Suse L3

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/