linux-kernel - Re: [PATCH 2/7] gpio: lynxpoint: remove unnecessary platform_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <51878D66.4000502@linux.intel.com>
Date:	Mon, 06 May 2013 14:00:54 +0300
From:	Mathias Nyman <mathias.nyman@...ux.intel.com>
To:	Jingoo Han <jg1.han@...sung.com>
CC:	'Grant Likely' <grant.likely@...retlab.ca>,
	'Linus Walleij' <linus.walleij@...aro.org>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/7] gpio: lynxpoint: remove unnecessary platform_set_drvdata()

On 05/06/2013 06:28 AM, Jingoo Han wrote:
> The driver core clears the driver data to NULL after device_release
> or on probe failure, since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d
> (device-core: Ensure drvdata = NULL when no driver is bound).
> Thus, it is not needed to manually clear the device driver data to NULL.
>
> Signed-off-by: Jingoo Han<jg1.han@...sung.com>
> ---
>   drivers/gpio/gpio-lynxpoint.c |    1 -
>   1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/gpio/gpio-lynxpoint.c b/drivers/gpio/gpio-lynxpoint.c
> index 86c17de..761c470 100644
> --- a/drivers/gpio/gpio-lynxpoint.c
> +++ b/drivers/gpio/gpio-lynxpoint.c
> @@ -447,7 +447,6 @@ static int lp_gpio_remove(struct platform_device *pdev)
>   	err = gpiochip_remove(&lg->chip);
>   	if (err)
>   		dev_warn(&pdev->dev, "failed to remove gpio_chip.\n");
> -	platform_set_drvdata(pdev, NULL);
>   	return 0;
>   }
>

Acked-by: Mathias Nyman <mathias.nyman@...ux.intel.com>


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/