linux-kernel - Re: [PATCH v4] extcon: Palmas Extcon Driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130506144010.GF13472@opensource.wolfsonmicro.com>
Date:	Mon, 6 May 2013 15:40:10 +0100
From:	Mark Brown <broonie@...nel.org>
To:	Kishon Vijay Abraham I <kishon@...com>
Cc:	myungjoo.ham@...sung.com, cw00.choi@...sung.com, balbi@...com,
	ldewangan@...dia.com, devicetree-discuss@...ts.ozlabs.org,
	linux-doc@...r.kernel.org, linux-kernel@...r.kernel.org,
	grant.likely@...aro.org, rob.herring@...xeda.com, rob@...dley.net,
	gg@...mlogic.co.uk, ruchika@...com, tony@...mide.com,
	sameo@...ux.intel.com
Subject: Re: [PATCH v4] extcon: Palmas Extcon Driver

On Mon, May 06, 2013 at 06:47:04PM +0530, Kishon Vijay Abraham I wrote:

> +		if (palmas_usb->linkstat != PALMAS_USB_STATE_VBUS) {
> +			if (palmas_usb->vbus_reg) {
> +				ret = regulator_enable(palmas_usb->vbus_reg);
> +				if (ret) {
> +					dev_dbg(palmas_usb->dev,
> +						"regulator enable failed\n");
> +					goto ret0;

This is very bad karma, why is the regulator optional?

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)