linux-kernel - Re: [PATCH 21/31] blk-throttle: implement sq_to_tg(), sq_to_td() and throtl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20130506204305.GG800@mtj.dyndns.org>
Date:	Mon, 6 May 2013 13:43:05 -0700
From:	Tejun Heo <tj@...nel.org>
To:	Vivek Goyal <vgoyal@...hat.com>
Cc:	axboe@...nel.dk, linux-kernel@...r.kernel.org, lizefan@...wei.com,
	containers@...ts.linux-foundation.org, cgroups@...r.kernel.org
Subject: Re: [PATCH 21/31] blk-throttle: implement sq_to_tg(), sq_to_td() and
 throtl_log()

On Mon, May 06, 2013 at 04:41:41PM -0400, Vivek Goyal wrote:
> On Mon, May 06, 2013 at 01:38:27PM -0700, Tejun Heo wrote:
> > On Mon, May 06, 2013 at 01:36:44PM -0400, Vivek Goyal wrote:
> > > On Wed, May 01, 2013 at 05:39:39PM -0700, Tejun Heo wrote:
> > > 
> > > [..]
> > > > +#define throtl_log(sq, fmt, args...)	do {				\
> > > > +	struct throtl_grp *__tg = sq_to_tg((sq));			\
> > > > +	struct throtl_data *__td = sq_to_td((sq));			\
> > > >  	char __pbuf[128];						\
> > > >  									\
> > > > -	blkg_path(tg_to_blkg(tg), __pbuf, sizeof(__pbuf));		\
> > > > -	blk_add_trace_msg((tg)->td->queue, "throtl %s " fmt, __pbuf, ##args); \
> > > > +	__pbuf[0] = ' ';						\
> > > > +	__pbuf[1] = '\0';						\
> > > > +	if ((__tg))							\
> > > > +		blkg_path(tg_to_blkg(__tg), __pbuf + 1, sizeof(__pbuf) - 1); \
> > > > +	blk_add_trace_msg(__td->queue, "throtl%s" fmt, __pbuf, ##args); \
> > > 
> > > We need one extra space ("throtl%s "), otherwise all the messages
> > > start right after cgroup path. We need a space between cgroup path
> > > and actual message.
> > 
> > Okay, we don't - __pbuf[0] = ' '.  The reason it's doing the above
> > instead of "throtl %s " is because when the path is nil, we don't
> > wanna print out two consecutive spaces, so AFAICS the code is correct.
> 
> What about space after the cgroup path info (when path is not nil).

Yeah, I mis-read it.  Fixing it right now.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/