linux-kernel - Re: [PATCH v4] extcon: Palmas Extcon Driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5188CE36.9010602@slimlogic.co.uk>
Date:	Tue, 07 May 2013 10:49:42 +0100
From:	Graeme Gregory <gg@...mlogic.co.uk>
To:	Kishon Vijay Abraham I <kishon@...com>
CC:	Mark Brown <broonie@...nel.org>, myungjoo.ham@...sung.com,
	cw00.choi@...sung.com, balbi@...com, ldewangan@...dia.com,
	devicetree-discuss@...ts.ozlabs.org, linux-doc@...r.kernel.org,
	linux-kernel@...r.kernel.org, grant.likely@...aro.org,
	rob.herring@...xeda.com, rob@...dley.net, ruchika@...com,
	tony@...mide.com, sameo@...ux.intel.com
Subject: Re: [PATCH v4] extcon: Palmas Extcon Driver

On 07/05/13 10:47, Kishon Vijay Abraham I wrote:
> Hi,
>
> On Tuesday 07 May 2013 01:28 PM, Mark Brown wrote:
>> On Tue, May 07, 2013 at 10:42:53AM +0530, Kishon Vijay Abraham I wrote:
>>> On Monday 06 May 2013 08:10 PM, Mark Brown wrote:
>>>> On Mon, May 06, 2013 at 06:47:04PM +0530, Kishon Vijay Abraham I
>>>> wrote:
>>>>
>>>>> +        if (palmas_usb->linkstat != PALMAS_USB_STATE_VBUS) {
>>>>> +            if (palmas_usb->vbus_reg) {
>>>>> +                ret = regulator_enable(palmas_usb->vbus_reg);
>>>>> +                if (ret) {
>>>>> +                    dev_dbg(palmas_usb->dev,
>>>>> +                        "regulator enable failed\n");
>>>>> +                    goto ret0;
>>
>>>> This is very bad karma, why is the regulator optional?
>>
>>> The platform can provide it's own vbus control in which case this is
>>> not needed.
>>
>> So why is there no interaction with this external VBUS control and how
>> does the driver distinguish between that and an error getting the
>> regulator?
>
> The platform specifies if it provides its own VBUS control by the dt
> property ti,no_control_vbus. So the driver will give an error only
> when *ti,no_control_vbus* is not set. Graeme?
>
> Thanks
> Kishon
That is correct, but as currently there are only two users I guess this
depends on Laxmans usecase. If he doesn't need this extra complexity I
would remove it for now. It was originally done with another SoC in mind!

Graeme

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/