linux-kernel - Re: [PATCH] Enable A20 gate

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130507112053.GA21162@gmail.com>
Date:	Tue, 7 May 2013 13:20:53 +0200
From:	Ingo Molnar <mingo@...nel.org>
To:	Syed Salman Mansoor <syed.salman.mansoor@...il.com>
Cc:	hpa@...or.com, tglx@...utronix.de, mingo@...hat.com,
	x86@...nel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Enable A20 gate


* Syed Salman Mansoor <syed.salman.mansoor@...il.com> wrote:

> From a5e4cd6cb1956d288b5a001f60699dc8b5528963 Mon Sep 17 00:00:00 2001
> From: Syed Salman Mansoor <syed.salman.mansoor@...il.com>
> Date: Tue, 7 May 2013 12:49:24 +0500
> Subject: [PATCH] Enable A20 gate
>  This is a patch to the a20.c file that fixes following
> warnings/errors found by the checkpatch.pl tool
>  i)  WARNING: please, no spaces at the start of a line
>  ii) WARNING: suspect code indent for conditional statements
>  iii) ERROR: trailing whitespace
> Signed-off-by: Syed Salman Mansoor <syed.salman.mansoor@...il.com>
> 
> ---
>  arch/x86/boot/a20.c |   46 +++++++++++++++++++++++-----------------------
>  1 files changed, 23 insertions(+), 23 deletions(-)
> 
> diff --git a/arch/x86/boot/a20.c b/arch/x86/boot/a20.c
> index 64a31a6..911d729 100644
> --- a/arch/x86/boot/a20.c
> +++ b/arch/x86/boot/a20.c
> @@ -129,37 +129,37 @@ static void enable_a20_fast(void)
> 
>  int enable_a20(void)
>  {
> -       int loops = A20_ENABLE_LOOPS;
> -       int kbc_err;
> + int loops = A20_ENABLE_LOOPS;
> + int kbc_err;
> 
> -       while (loops--) {
> -       /* First, check to see if A20 is already enabled
> + while (loops--) {
> + /* First, check to see if A20 is already enabled
>    (legacy free, etc.) */
> -       if (a20_test_short())
> -       return 0;
> -
> + if (a20_test_short())
> + return 0;
> +
>         /* Next, try the BIOS (INT 0x15, AX=0x2401) */
>         enable_a20_bios();
> -       if (a20_test_short())
> -       return 0;
> -
> + if (a20_test_short())
> + return 0;
> +
>         /* Try enabling A20 through the keyboard controller */
>         kbc_err = empty_8042();
> 
> -       if (a20_test_short())
> -       return 0; /* BIOS worked, but with delayed reaction */
> -
> -       if (!kbc_err) {
> -       enable_a20_kbc();
> -       if (a20_test_long())
> -       return 0;
> + if (a20_test_short())
> + return 0; /* BIOS worked, but with delayed reaction */
> +
> + if (!kbc_err) {
> + enable_a20_kbc();
> + if (a20_test_long())
> + return 0;
>         }
> -
> +
>         /* Finally, try enabling the "fast A20 gate" */
>         enable_a20_fast();
> -       if (a20_test_long())
> -       return 0;
> -       }
> -
> -       return -1;
> + if (a20_test_long())
> + return 0;
> + }
> +
> + return -1;
>  }
> --
> 1.7.2.5

The patch is probably corrupted or not against latest upstream, and the 
title of the patch has no relation to what the patch actually does.

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/