[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CACRpkdb3cEhCtc=zdq6cHMnh9Hc4ELb3jDXqyhV5kzzKJ-Nxiw@mail.gmail.com>
Date: Tue, 7 May 2013 21:59:34 +0200
From: Linus Walleij <linus.walleij@...aro.org>
To: "Kim, Milo" <Milo.Kim@...com>
Cc: Bryan Wu <cooloney@...il.com>,
Gabriel Fernandez <gabriel.fernandez@...ricsson.com>,
"linux-leds@...r.kernel.org" <linux-leds@...r.kernel.org>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/2] leds: lp55xx: support dynamic channel settings in the
device tree structure
On Tue, May 7, 2013 at 9:14 AM, Kim, Milo <Milo.Kim@...com> wrote:
> Currently, the LP55xx DT structure supports max 3 channels.
> However, LP5523 has max 9 channels and LP5562 has 4 channels.
> To enhance this constraint, the DT structure has been changed.
>
> (a) Use the child node for various channel settings instead of fixed array
> (b) Remove 'num_channel' property.
> This value can be retrieved by counting the children node.
> (c) 'chan-name' property supported
> (d) Documentation updates for LP5521 and LP5523
>
> Cc: Linus Walleij <linus.walleij@...aro.org>
> Cc: Gabriel Fernandez <gabriel.fernandez@...ricsson.com>
> Signed-off-by: Milo(Woogyom) Kim <milo.kim@...com>
This is looking very good to me.
Reviewed-by: Linus Walleij <linus.walleij@...aro.org>
Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists