lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 7 May 2013 10:21:09 +0800 From: Gao feng <gaofeng@...fujitsu.com> To: viro@...iv.linux.org.uk, eparis@...hat.com, ebiederm@...ssion.com, sgrubb@...hat.com, akpm@...ux-foundation.org, serge.hallyn@...ntu.com, davem@...emloft.net Cc: netdev@...r.kernel.org, containers@...ts.linux-foundation.org, linux-kernel@...r.kernel.org, linux-audit@...hat.com, Gao feng <gaofeng@...fujitsu.com> Subject: [PATCH RFC 48/48] Audit: allow root user of un-init user namespace to set audit This patch reduce the permission check of setting audit. We already finish the user namespace support for audit, now we can allow the root user of uninit userns to set and use the audit subsystem. Signed-off-by: Gao feng <gaofeng@...fujitsu.com> --- kernel/audit.c | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/kernel/audit.c b/kernel/audit.c index 59e5cca..8a27197 100644 --- a/kernel/audit.c +++ b/kernel/audit.c @@ -571,11 +571,6 @@ static int audit_netlink_ok(struct sk_buff *skb, u16 msg_type) { int err = 0; - /* Only support the initial namespaces for now. */ - if ((current_user_ns() != &init_user_ns) || - (task_active_pid_ns(current) != &init_pid_ns)) - return -EPERM; - switch (msg_type) { case AUDIT_GET: case AUDIT_LIST: @@ -590,13 +585,13 @@ static int audit_netlink_ok(struct sk_buff *skb, u16 msg_type) case AUDIT_TTY_SET: case AUDIT_TRIM: case AUDIT_MAKE_EQUIV: - if (!capable(CAP_AUDIT_CONTROL)) + if (!ns_capable(current_user_ns(), CAP_AUDIT_CONTROL)) err = -EPERM; break; case AUDIT_USER: case AUDIT_FIRST_USER_MSG ... AUDIT_LAST_USER_MSG: case AUDIT_FIRST_USER_MSG2 ... AUDIT_LAST_USER_MSG2: - if (!capable(CAP_AUDIT_WRITE)) + if (!ns_capable(current_user_ns(), CAP_AUDIT_WRITE)) err = -EPERM; break; default: /* bad msg */ -- 1.8.1.4 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists