linux-kernel - Re: [PATCH 1/6] ASoC: ab8500-codec: Add missing ad_to

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130508083017.GB1526@balto.lan>
Date:	Wed, 8 May 2013 10:30:17 +0200
From:	Fabio Baltieri <fabio.baltieri@...aro.org>
To:	Lee Jones <lee.jones@...aro.org>
Cc:	Mark Brown <broonie@...nel.org>,
	Liam Girdwood <lgirdwood@...il.com>,
	alsa-devel@...a-project.org, linux-kernel@...r.kernel.org,
	Linus Walleij <linus.walleij@...aro.org>,
	Ola Lilja <ola.o.lilja@...ricsson.com>
Subject: Re: [PATCH 1/6] ASoC: ab8500-codec: Add missing ad_to_slot
 definitions

On Wed, May 08, 2013 at 08:53:28AM +0100, Lee Jones wrote:
> I'm sure this is just me, but:
> 
> >    0 to  7 corresponds to AD_OUTx slots
> > char * const enum_ad_to_slot_map[] = {"AD_OUT1",    0
>                                                       1..5 ???
> >  					"AD_OUT7",    6
> >  					"AD_OUT8",    7

I'm a bit confused... the first one was from the diff header, while OUT7 and
OUT8 are context lines, so 1 to 5 are already there but not shown in the
patch.  The final array is like:

static const char * const enum_ad_to_slot_map[] = {"AD_OUT1",
                                        "AD_OUT2",
                                        "AD_OUT3",
                                        "AD_OUT4",
                                        "AD_OUT5",
                                        "AD_OUT6",
                                        "AD_OUT7",
                                        "AD_OUT8",
                                        "zeroes",
                                        "zeroes",
                                        "zeroes",
                                        "zeroes",
                                        "tristate",
                                        "tristate",
                                        "tristate",
                                        "tristate"};

Is it ok?

Fabio

> >    8 to 11 corresponds to zero output
> >  					"zeroes",     8
> > +					"zeroes",     9
> > +					"zeroes",     10
> > +					"zeroes",     11
> >   12 to 15 sets the output in tristate mode
> > +					"tristate",   12
> > +					"tristate",   13
> > +					"tristate",   14
> >  					"tristate"};  15
> 
> 
> -- 
> Lee Jones
> Linaro ST-Ericsson Landing Team Lead
> Linaro.org │ Open source software for ARM SoCs
> Follow Linaro: Facebook | Twitter | Blog

-- 
Fabio Baltieri
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/