linux-kernel - Re: [PATCH 4/6] ASoC: ux500: Update tx tdm slots configuration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130508110149.GF7478@sirena.org.uk>
Date:	Wed, 8 May 2013 12:01:49 +0100
From:	Mark Brown <broonie@...nel.org>
To:	Fabio Baltieri <fabio.baltieri@...aro.org>
Cc:	Liam Girdwood <lgirdwood@...il.com>, alsa-devel@...a-project.org,
	linux-kernel@...r.kernel.org,
	Linus Walleij <linus.walleij@...aro.org>,
	Lee Jones <lee.jones@...aro.org>,
	Ola Lilja <ola.o.lilja@...ricsson.com>
Subject: Re: [PATCH 4/6] ASoC: ux500: Update tx tdm slots configuration

On Wed, May 08, 2013 at 09:14:19AM +0200, Fabio Baltieri wrote:
> Update ab8500-codec and mop500_ab8500 tx slot configuration to reflect
> the actual one used by STE.  Also update a wrong comment in the process.

This seems wrong, the individual chip drivers should just be doing
whatever they're being told by the machine driver.  Sounds like there's
two fixes needed here - one is to change the TDM API so that the chip
drivers are just implementing configuration supplied by the machine
driver and the other is to change the configuration being done to
whatever is desired.

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)