linux-kernel - Re: [PATCH 1/2] regulator: support operating mode in the device tree structure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 8 May 2013 12:12:10 +0100
From:	Mark Brown <broonie@...nel.org>
To:	"Kim, Milo" <Milo.Kim@...com>
Cc:	Liam Girdwood <lgirdwood@...il.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/2] regulator: support operating mode in the device tree
 structure

On Tue, May 07, 2013 at 11:46:12PM +0000, Kim, Milo wrote:

> It's my intention to guarantee same operations in the DT as the regulator
> constraints in the platform side.
> In case a regulator has specific 'valid_modes_mask', the operating mode is 
> unable to be set with the device tree.
> For some regulator drivers such as LP8720/5 and LP8788, this patch would be
> useful because there is no difference between configuration in the platform side
>  and the device tree.

I understand what the patch is doing but there's no reason why the
device tree binding needs to map directly onto our internal
configuration and indeed in cases where we didn't make ideal choices
that's not what we want to do.  Providing a binding that corresponds to
what the chip itself calls the configuration seems more useful.

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)