linux-kernel - Re: [PATCH 05/15] connection tracking helper for SLP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130508020328.GA7747@localhost>
Date:	Wed, 8 May 2013 04:03:28 +0200
From:	Pablo Neira Ayuso <pablo@...filter.org>
To:	Jiri Slaby <jslaby@...e.cz>
Cc:	jirislaby@...il.com, linux-kernel@...r.kernel.org,
	Jiri Bohac <jbohac@...e.cz>, netfilter-devel@...r.kernel.org,
	netfilter@...r.kernel.org, coreteam@...filter.org,
	netdev@...r.kernel.org, "David S. Miller" <davem@...emloft.net>,
	Patrick McHardy <kaber@...sh.net>
Subject: Re: [PATCH 05/15] connection tracking helper for SLP

On Tue, May 07, 2013 at 04:18:13PM +0200, Jiri Slaby wrote:
> From: Jiri Bohac <jbohac@...e.cz>
> 
> A simple connection tracking helper for SLP. Marks replies to a
> SLP broadcast query as ESTABLISHED to allow them to pass through the
> firewall.
> 
> Signed-off-by: Jiri Bohac <jbohac@...e.cz>
> Signed-off-by: Jiri Slaby <jslaby@...e.cz>
> Cc: netfilter-devel@...r.kernel.org
> Cc: netfilter@...r.kernel.org
> Cc: coreteam@...filter.org
> Cc: netdev@...r.kernel.org
> Cc: "David S. Miller" <davem@...emloft.net>
> Cc: Patrick McHardy <kaber@...sh.net>
> Cc: Pablo Neira Ayuso <pablo@...filter.org>
> ---
>  net/netfilter/Kconfig            |  15 +++++
>  net/netfilter/Makefile           |   1 +
>  net/netfilter/nf_conntrack_slp.c | 131 +++++++++++++++++++++++++++++++++++++++
>  3 files changed, 147 insertions(+)
>  create mode 100644 net/netfilter/nf_conntrack_slp.c
> 
> diff --git a/net/netfilter/Kconfig b/net/netfilter/Kconfig
> index 56d22ca..ec61b30 100644
> --- a/net/netfilter/Kconfig
> +++ b/net/netfilter/Kconfig
> @@ -320,6 +320,21 @@ config NF_CONNTRACK_TFTP
>  
>  	  To compile it as a module, choose M here.  If unsure, say N.
>  
> +config NF_CONNTRACK_SLP
> +	tristate "SLP protocol support"
> +	depends on NF_CONNTRACK
> +	depends on NETFILTER_ADVANCED
> +	help
> +	  SLP queries are sometimes sent as broadcast messages from an
> +	  unprivileged port and responded to with unicast messages to the
> +	  same port. This make them hard to firewall properly because connection
> +	  tracking doesn't deal with broadcasts. This helper tracks locally
> +	  originating broadcast SLP queries and the corresponding
> +	  responses. It relies on correct IP address configuration, specifically
> +	  netmask and broadcast address.

We have the user-space helper infrastructure in the conntrack-tools,
this helper has to go there.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/