linux-kernel - Re: [PATCH] rtc: rtc-tile: add missing platform_device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAPgLHd_jEksFgC2nmKNoRvGeagZh5ZWXaLPkcsyxrdj=JxCGfA@mail.gmail.com>
Date:	Wed, 8 May 2013 10:46:21 +0800
From:	Wei Yongjun <weiyj.lk@...il.com>
To:	akpm@...ux-foundation.org
Cc:	a.zummo@...ertech.it, yongjun_wei@...ndmicro.com.cn,
	rtc-linux@...glegroups.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] rtc: rtc-tile: add missing platform_device_unregister()
 when module exit

On 05/08/2013 07:28 AM, Andrew Morton wrote:
> On Sun, 5 May 2013 13:07:00 +0800 Wei Yongjun <weiyj.lk@...il.com> wrote:
>
>> From: Wei Yongjun <yongjun_wei@...ndmicro.com.cn>
>>
>> We have registered platform device when module init, and
>> need unregister it when module exit.
>>
>> ...
>>
>> --- a/drivers/rtc/rtc-tile.c
>> +++ b/drivers/rtc/rtc-tile.c
>> @@ -146,6 +146,7 @@ exit_driver_unregister:
>>   */
>>  static void __exit tile_rtc_driver_exit(void)
>>  {
>> +	platform_device_unregister(tile_rtc_platform_device);
>>  	platform_driver_unregister(&tile_rtc_platform_driver);
>>  }
> We don't need to do a platform_device_put(), as tile_rtc_driver_init()
> does?

platform_device_unregister() is a warp of platform_device_del() and
platform_device_put(), it is used after platform_device_add() success.
So extra platform_device_put() does not need.
 

> drivers/rtc/rtc-stmp3xxx.c appears to need the same fix.

Yes, you are right. I'll try to submit another patch to fix this unless
someone beats me at it.


>
>   
>
>


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/