linux-kernel - Re: [PATCH 0/3] firmware: Fix usermodehelper deadlock at shutdown

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <s5ha9o5wi7j.wl%tiwai@suse.de>
Date:	Wed, 08 May 2013 18:26:56 +0200
From:	Takashi Iwai <tiwai@...e.de>
To:	Ming Lei <ming.lei@...onical.com>
Cc:	linux-kernel@...r.kernel.org,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Subject: Re: [PATCH 0/3] firmware: Fix usermodehelper deadlock at shutdown

At Thu, 9 May 2013 00:07:17 +0800,
Ming Lei wrote:
> 
> Hi Takashi,
> 
> Sorry for not CC list.
> 
> On Wed, May 8, 2013 at 2:56 PM, Takashi Iwai <tiwai@...e.de> wrote:
> > Hi,
> >
> > this is a series of patches for the issue we faced in the firmware
> > loader code during debugging the problem with dell_rbu driver with
> > 3.9 kernel.
> >
> > The original problem was that the shutdown gets stuck when DELL BIOS
> > update is performed.  This turned out to be a problem in the firmware
> > loader.  Although the reason of dell_rbu driver breakage is still
> 
> Sorry, from these patchset, I can't see why it is a problem in firmware.
> 
> > unclear, we should fix the firmware loader side, at least, not to
> > stall during shutdown.
> 
> Firstly you need to describe what/why is the stall? In fact, firmware
> loading can't stall forever and it will timeout, but the current 60sec
> timeout might be too long.

The timeout check is activated only when uevent flag is set, and
dell_rbu driver doesn't set it explicitly (because it's not supposed
to be handled via udev or whatever).


Takashi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/