linux-kernel - Re: [PATCH v5, part4 20/41] mm/h8300: prepare for removing num_physpages and simplify mem

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <518AA7A0.1020702@cogentembedded.com>
Date:	Wed, 08 May 2013 23:29:36 +0400
From:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:	Jiang Liu <liuj97@...il.com>
CC:	Andrew Morton <akpm@...ux-foundation.org>,
	Jiang Liu <jiang.liu@...wei.com>,
	David Rientjes <rientjes@...gle.com>,
	Wen Congyang <wency@...fujitsu.com>,
	Mel Gorman <mgorman@...e.de>, Minchan Kim <minchan@...nel.org>,
	KAMEZAWA Hiroyuki <kamezawa.hiroyu@...fujitsu.com>,
	Michal Hocko <mhocko@...e.cz>,
	James Bottomley <James.Bottomley@...senPartnership.com>,
	David Howells <dhowells@...hat.com>,
	Mark Salter <msalter@...hat.com>,
	Jianguo Wu <wujianguo@...wei.com>, linux-mm@...ck.org,
	linux-arch@...r.kernel.org, linux-kernel@...r.kernel.org,
	Yoshinori Sato <ysato@...rs.sourceforge.jp>,
	Geert Uytterhoeven <geert@...ux-m68k.org>
Subject: Re: [PATCH v5, part4 20/41] mm/h8300: prepare for removing num_physpages
 and simplify mem_init()

Hello.

On 05/08/2013 08:26 PM, Sergei Shtylyov wrote:

>
>> Prepare for removing num_physpages and simplify mem_init().
>
>> Signed-off-by: Jiang Liu <jiang.liu@...wei.com>
>> Cc: Yoshinori Sato <ysato@...rs.sourceforge.jp>
>> Cc: Geert Uytterhoeven <geert@...ux-m68k.org>
>> Cc: linux-kernel@...r.kernel.org
>> ---
>>   arch/h8300/mm/init.c |   34 ++++++++--------------------------
>>   1 file changed, 8 insertions(+), 26 deletions(-)
>
>> diff --git a/arch/h8300/mm/init.c b/arch/h8300/mm/init.c
>> index 22fd869..0088f3a 100644
>> --- a/arch/h8300/mm/init.c
>> +++ b/arch/h8300/mm/init.c
>> @@ -121,40 +121,22 @@ void __init paging_init(void)
>>
>>   void __init mem_init(void)
>>   {
>> -    int codek = 0, datak = 0, initk = 0;
>> -    /* DAVIDM look at setup memory map generically with reserved 
>> area */
>> -    unsigned long tmp;
>> -    extern unsigned long  _ramend, _ramstart;
>> -    unsigned long len = &_ramend - &_ramstart;
>> -    unsigned long start_mem = memory_start; /* DAVIDM - these must 
>> start at end of kernel */
>> -    unsigned long end_mem   = memory_end; /* DAVIDM - this must not 
>> include kernel stack at top */
>> +    unsigned long codesize = _etext - _stext;
>>
>>   #ifdef DEBUG
>> -    printk(KERN_DEBUG "Mem_init: start=%lx, end=%lx\n", start_mem, 
>> end_mem);
>> +    pr_debug("Mem_init: start=%lx, end=%lx\n", memory_start, 
>> memory_end);
>>   #endif
>
>     pr_debug() only prints something if DEBUG is #define'd, so you can 
> drop the #ifdef here.

     Although, not necessarily: it also supports CONFIG_DYNAMIC_DEBUG -- 
look at how pr_debug() is defined.
So this doesn't seem to be an equivalent change, and I suggest not doing 
it at all.

WBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/