linux-kernel - Re: [PATCH] ACPI: battery: Changed leading spaces to tab

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4297619.TAqcfu2p5L@vostro.rjw.lan>
Date:	Thu, 09 May 2013 00:05:35 +0200
From:	"Rafael J. Wysocki" <rjw@...k.pl>
To:	GBGamer <npmazzuca@...il.com>
Cc:	lenb@...nel.org, linux-acpi@...r.kernel.org,
	linux-kernel@...r.kernel.org, GBGamer <nicholas@...zucastuff.com>
Subject: Re: [PATCH] ACPI: battery: Changed leading spaces to tab

On Wednesday, May 08, 2013 09:09:29 AM GBGamer wrote:
> Fixed coding style problems in battery.c

First off, patches without a sign-off are not applicable.

Second, ->

> ---
>  drivers/acpi/battery.c |    6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/acpi/battery.c b/drivers/acpi/battery.c
> index e710045..3c1784b 100644
> --- a/drivers/acpi/battery.c
> +++ b/drivers/acpi/battery.c
> @@ -663,9 +663,9 @@ static void acpi_battery_quirks(struct acpi_battery *battery)
>  	if (test_bit(ACPI_BATTERY_QUIRK_PERCENTAGE_CAPACITY, &battery->flags))
>  		return ;
>  
> -        if (battery->full_charge_capacity == 100 &&
> -            battery->rate_now == ACPI_BATTERY_VALUE_UNKNOWN &&
> -            battery->capacity_now >=0 && battery->capacity_now <= 100) {
> +	if (battery->full_charge_capacity == 100 &&
> +		battery->rate_now == ACPI_BATTERY_VALUE_UNKNOWN &&
> +		battery->capacity_now >=0 && battery->capacity_now <= 100) {

-> this isn't entirely correct, because the indentation pattern used in the
kernel for continuations of if () conditionals is one tab and four spaces
(whereas you've used two tabs).

>  		set_bit(ACPI_BATTERY_QUIRK_PERCENTAGE_CAPACITY, &battery->flags);
>  		battery->full_charge_capacity = battery->design_capacity;
>  		battery->capacity_now = (battery->capacity_now *

Thanks,
Rafael


-- 
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/