linux-kernel - Re: [PATCH 10/13] perf kvm: add live mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <518BAB0B.60401@gmail.com>
Date:	Thu, 09 May 2013 07:56:27 -0600
From:	David Ahern <dsahern@...il.com>
To:	Namhyung Kim <namhyung@...nel.org>
CC:	linux-kernel@...r.kernel.org, acme@...stprotocols.net,
	mingo@...nel.org, fweisbec@...il.com, peterz@...radead.org,
	jolsa@...hat.com, xiaoguangrong@...ux.vnet.ibm.com
Subject: Re: [PATCH 10/13] perf kvm: add live mode

On 5/9/13 2:45 AM, Namhyung Kim wrote:
> On Wed,  8 May 2013 22:31:46 -0600, David Ahern wrote:
> [SNIP]
>> +static int perf_kvm__timerfd_create(struct perf_kvm_stat *kvm)
>> +{
>> +	struct itimerspec new_value;
>> +	struct timespec now;
>> +	int rc = -1;
>> +
>> +	kvm->timerfd = timerfd_create(CLOCK_MONOTONIC, TFD_NONBLOCK);
>> +	if (kvm->timerfd < 0) {
>> +		pr_err("timerfd_create failed\n");
>> +		goto out;
>> +	}
>> +
>> +	if (clock_gettime(CLOCK_MONOTONIC, &now) != 0) {
>> +		pr_err("clock_gettime failed: %d\n", errno);
>> +		close(kvm->timerfd);
>> +		goto out;
>> +	}
>> +
>> +	new_value.it_value.tv_sec = now.tv_sec + kvm->display_time;
>> +	new_value.it_value.tv_nsec = now.tv_nsec;
>> +	new_value.it_interval.tv_sec = kvm->display_time;
>> +	new_value.it_interval.tv_nsec = 0;
>> +
>> +	if (timerfd_settime(kvm->timerfd, TFD_TIMER_ABSTIME,
>> +			    &new_value, NULL) != 0) {
>
> Looks like no need to use ABSTIME.

hmmm.... I did that for a reason. I forget why now. Let me poke around 
with it and see if I can remember.

David

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/