linux-kernel - Re: [PATCH] x86: make stat/statfs 64-bit for x86

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 9 May 2013 00:08:45 -0400
From:	Mike Frysinger <vapier@...too.org>
To:	"H. Peter Anvin" <hpa@...or.com>
Cc:	x86@...nel.org, Thomas Gleixner <tglx@...utronix.de>,
	Ingo Molnar <mingo@...hat.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] x86: make stat/statfs 64-bit for x86_64 kernels

On Thursday 09 May 2013 00:04:03 H. Peter Anvin wrote:
> On 05/08/2013 09:00 PM, Mike Frysinger wrote:
> > When including these headers in the x32 ABI, the structs get declared
> > with 32bit sizes which is incorrect.  Use long long and such to make
> > it work both with x32 and x86_64.
> 
> I'm not sure if it is okay to change the types, even within the same
> size.  Perhaps use __u64/__s64?

sorry, i don't follow.  changing types isn't ok (unsigned long to unsigned 
long long), but changing to __u64 is ok (unsigned long to __u64 which is 
typedefed to unsigned long long) ?

i don't have a problem using __u64/__s64, i just don't understand your logic.
-mike

Download attachment "signature.asc " of type "application/pgp-signature" (837 bytes)