linux-kernel - RE: [PATCH] aerdrv: Move cper_print

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <A961433CDFF2F640A2866803152E61F95177AFA9@G4W3219.americas.hpqcorp.net>
Date:	Thu, 9 May 2013 19:10:36 +0000
From:	"Ortiz, Lance E" <lance.oritz@...com>
To:	"Rafael J. Wysocki" <rjw@...k.pl>
CC:	"bhelgaas@...gle.com" <bhelgaas@...gle.com>,
	"lance_ortiz@...mail.com" <lance_ortiz@...mail.com>,
	"jiang.liu@...wei.com" <jiang.liu@...wei.com>,
	"tony.luck@...el.com" <tony.luck@...el.com>,
	"bp@...en8.de" <bp@...en8.de>,
	"rostedt@...dmis.org" <rostedt@...dmis.org>,
	"mchehab@...hat.com" <mchehab@...hat.com>,
	"linux-acpi@...r.kernel.org" <linux-acpi@...r.kernel.org>,
	"linux-pci@...r.kernel.org" <linux-pci@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] aerdrv: Move cper_print_pcie() out of interrupt context

Rafael,  

Thanks for your feedback.

> The way the changes are described here isn't particularly clear to me.

I will try to make it a little more clear.

> Also, since aer_recover_work_func() is going to be the only existing
> caller of
> cper_print_aer() after this change, as far as I can say, and it doesn't
> use the
> function's first argument, that argument should be dropped entirely.

The truth is, the function cper_print_aer() really needs to be re-written so it is consistent with aer_print_error() in how it outputs information.  Right now, the output is formatted very differently.  I was planning on doing that at a later date, but fix the warning now.  I might add a TODO comment in the code for this.

The reason I did not remove the argument in cper_print_aer() is because 'prefix' is used in the call to cper_print_bits(), and I passed through an empty string to make sure that function worked correctly.  I can try to clean it up.

Lance