linux-kernel - Re: [PATCH 04/27] block: Convert integrity to bvec_alloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAErSpo5-wVvBivB4pr8_hg2WdzW_yxodcTkSfssJcfEB6Cyd9Q@mail.gmail.com>
Date:	Thu, 9 May 2013 12:43:29 -0700
From:	Bjorn Helgaas <bhelgaas@...gle.com>
To:	Kent Overstreet <koverstreet@...gle.com>
Cc:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	axboe@...nel.dk, "Martin K. Petersen" <martin.petersen@...cle.com>
Subject: Re: [PATCH 04/27] block: Convert integrity to bvec_alloc_bs()

On Tue, Feb 19, 2013 at 4:22 PM, Kent Overstreet <koverstreet@...gle.com> wrote:

> diff --git a/fs/bio-integrity.c b/fs/bio-integrity.c
> index 94fa1c5..8c4c604 100644
> --- a/fs/bio-integrity.c
> +++ b/fs/bio-integrity.c
> ...
> @@ -766,13 +733,14 @@ void bioset_integrity_free(struct bio_set *bs)
>  {
>         if (bs->bio_integrity_pool)
>                 mempool_destroy(bs->bio_integrity_pool);
> +
> +       if (bs->bvec_integrity_pool)
> +               mempool_destroy(bs->bio_integrity_pool);

I think this is a copy-and-paste error that results in using
bs->bio_integrity_pool after it has been freed.  Found by Coverity
(CID 1020654).

>  }
>  EXPORT_SYMBOL(bioset_integrity_free);
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/