linux-kernel - Re: [PATCH v2] kernel: audit_tree: resource management: need put

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20130509131108.8a70aa5116ff0e3c250feb8b@linux-foundation.org>
Date:	Thu, 9 May 2013 13:11:08 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Chen Gang <gang.chen@...anux.com>
Cc:	Eric Paris <eparis@...hat.com>, Al Viro <viro@...iv.linux.org.uk>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] kernel: audit_tree: resource management: need
 put_tree and goto Err when failure occures

On Thu, 09 May 2013 20:53:06 +0800 Chen Gang <gang.chen@...anux.com> wrote:

> get_tree() in audit_add_tree_rule() is needed (my original conclusion is incorrect).

OK..

> But we need let 'rule->tree = NULL;' firstly, so can protect rule itself freed in kill_rules().

I'll believe you ;) I turned this into a proper patch and added your
(missed) Signed-off-by:.

> For me, after 'rule->tree = NULL', all things seems fine !!

Well, what was wrong before?  Is there some user-triggerable
misbehaviour which you observed?  If so, please describe it.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/