linux-kernel - Re: [git pull] more vfs.git stuff

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+55aFwfOS0uNrjuB92ntNsOMZYKOAABw+i29BoPLwhMOY+-hA@mail.gmail.com>
Date:	Thu, 9 May 2013 13:21:47 -0700
From:	Linus Torvalds <torvalds@...ux-foundation.org>
To:	Al Viro <viro@...iv.linux.org.uk>
Cc:	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	linux-fsdevel <linux-fsdevel@...r.kernel.org>
Subject: Re: [git pull] more vfs.git stuff

On Thu, May 9, 2013 at 1:12 PM, Linus Torvalds
<torvalds@...ux-foundation.org> wrote:
>
> Hmm. I get one more commit - a racy usbmon thing. Which looks fine per
> se, but would look even better if it just made mmap_active an atomic_t
> instead, wouldn't you say?

Oh, I see, the spinlock protects the read too and the logic there. Not
that I'm at all sure we care, since if that code races with somebody
else doing an mmap, there's a race at a much higher level anyway. So I
don't think the spinlock really gives any more serialization between
the reading/writing of that mmap_active count. You're going to get
either the old or the new value anyway, and an atomic will do that
too.

So whatever. I just don't want to pull stuff that gets me unexpected
patches that weren't in the pull request.

                 Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/